MaxResource of Queue

[k82cn]

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

Description:

Support MaxResource of queue by admission controller & queue controller.

xref kubernetes-retired/kube-batch#452

• Update Queue API (Cherry pick .spec.Capability of Queue #131)
• Added QueueController (Queue controller and related cli #16)
• Added Queue admission controller

[k82cn]

/kind feature
/priority high

[k82cn]

/assign @hzxuzhonghu

[k82cn]

I'm thinking whether we should enhance enqueue action to consider queue's capability, so we can enqueue "high priority" jobs. And leverage #135 to make sure the pod will not be create if not enough resources.

[k82cn]

/cc @wangyuqing4 @jiaxuanzhou

[jiaxuanzhou]

I'm thinking whether we should enhance enqueue action to consider queue's capability, so we can enqueue "high priority" jobs. And leverage #135 to make sure the pod will not be create if not enough resources.

yeah, agree with u, but the behaviors of the queue controller better be designed to support the dynamic changes of the specs(either the pg number or the resource quota), so the update func of queue controller and admission controller could work together to notify the changes to make the decision whether to create or delay the creation of the pods.

[hzxuzhonghu]

I am not sure what does spec.Capability and MaxResource mean? And also how does it cooperate with spec.Weight. I have no context at all.

[jiaxuanzhou]

@hzxuzhonghu
1, the weight means the weight of resource of the whole cluster for one queue
2, MaxResource is manual defined by the end-user for the queue may be less or more than the weight of the queue

[hzxuzhonghu]

Then these two fields are both optional, and if both specified, how to deal with the conflict?

[jiaxuanzhou]

Then these two fields are both optional, and if both specified, how to deal with the conflict?

maxResource often used for scenario of resource overmatching, but the weight is for cluster scope, so by my side, weight has higher privilege.

[hzxuzhonghu]

So I would expect a detailed design doc.