This repository has been archived by the owner on Jul 7, 2019. It is now read-only.
Implement queue Capability #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k82cn
reviewed
May 8, 2019
|
|
||
| pgResource := api.NewResource(*job.PodGroup.Spec.MinResources) | ||
| // The queue resource quota limit has not reached | ||
| if pgResource.Clone().Add(ssn.Queues[queue.UID].Allocated).LessEqual(api.NewResource(queue.Queue.Spec.Capability)) { |
There was a problem hiding this comment.
we should add an Enqueue callback to ask plugin whehter it's ready to enqueue, refer to JobReady callback.
k82cn
reviewed
May 14, 2019
| queue := ssn.Queues[queueID] | ||
| pgResource := api.NewResource(*job.PodGroup.Spec.MinResources) | ||
| // The queue resource quota limit has not reached | ||
| if pgResource.Clone().Add(attr.allocated).LessEqual(api.NewResource(queue.Queue.Spec.Capability)) { |
There was a problem hiding this comment.
We may also consider maxPodGroup number as one of resource, we can open another PR for it.
|
LGTM overall, please ping me when CI is happy with that. |
penggu
pushed a commit
to penggu/kube-batch
that referenced
this pull request
May 14, 2019
Added Pod events.
|
/lgtm |
volcano-sh-bot
added
approved
k82cn
approved these changes
May 15, 2019
|
/lgtm |
|
/lgtm |
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Implement queue Capability
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Implement queue Capability
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Implement queue Capability
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Partially fix volcano-sh/volcano#117
Special notes for your reviewer:
Release note: