Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using the high-availability mode, when Volcano is uninstalled, two resources will remain. #2979

Closed
gj409237405 opened this issue Jul 19, 2023 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@gj409237405
Copy link
Contributor

gj409237405 commented Jul 19, 2023

this issue is releated to #2980

What would you like to be added:

change resourcelock.New(resourcelock.ConfigMapsLeasesResourceLock to resourcelock.New(resourcelock.LeasesResourceLock

Why is this needed:

it will use fewer resource

beofore this PR

kubectl get cm -A
kube-system vc-controller-manager 0 171d
kube-system volcano 0 171d
kubectl get leases -A
kube-system vc-controller-manager volcano-controller-6bdcc5ccdf-qt7sx_0aeaadca-4c71-4cc3-945b-19a06db5e6b1 171d
kube-system volcano volcano-scheduler-1_5d9b01e2-01c5-4d85-ab48-9f931ec77efc 171d

after this PR
only left leases
kubectl get leases -A
kube-system vc-controller-manager volcano-controller-6bdcc5ccdf-qt7sx_0aeaadca-4c71-4cc3-945b-19a06db5e6b1 171d
kube-system volcano volcano-scheduler-1_5d9b01e2-01c5-4d85-ab48-9f931ec77efc 171d

@gj409237405 gj409237405 added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 19, 2023
@lowang-bh
Copy link
Member

this issue can close now. @gj199575

@lowang-bh
Copy link
Member

/close

@volcano-sh-bot
Copy link
Contributor

@lowang-bh: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants