Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-vendor files changed when update k8s to v1.23.0 #1915

Closed
wants to merge 1 commit into from
Closed

non-vendor files changed when update k8s to v1.23.0 #1915

wants to merge 1 commit into from

Conversation

Thor-wl
Copy link
Contributor

@Thor-wl Thor-wl commented Dec 21, 2021

ref: #1910
In order to make it clear for reviewers, separate the non-vendor files from the whole PR .
Signed-off-by: Thor-wl 13164644535@163.com

@Thor-wl
non-vendor files changed when update k8s to v1.23.0
0a18cf6 
Signed-off-by: Thor-wl <13164644535@163.com>
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Thor-wl Thor-wl requested review from wpeng102 and removed request for merryzhou December 21, 2021 12:35
@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 21, 2021
@Thor-wl Thor-wl requested review from william-wang and removed request for wpeng102 December 22, 2021 01:29
william-wang
william-wang reviewed Dec 22, 2021
View reviewed changes
pkg/scheduler/cache/cache.go
@@ -36,7 +36,7 @@ import (
infov1 "k8s.io/client-go/informers/core/v1"
schedv1 "k8s.io/client-go/informers/scheduling/v1"
storagev1 "k8s.io/client-go/informers/storage/v1"
storagev1alpha1 "k8s.io/client-go/informers/storage/v1alpha1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "storagev1alpha1" should be changed. Additionally, is the change compatible for v1alpha1 object?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "storagev1alpha1" should be changed. Additionally, is the change compatible for v1alpha1 object?

Sorry for the clerical error. In fact, storagev1apha1 has already been changed to storagev1beta1. The reference: https://github.com/volcano-sh/volcano/pull/1910/files

@Thor-wl Thor-wl closed this Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@william-wang william-wang william-wang left review comments

@shinytang6 shinytang6 Awaiting requested review from shinytang6

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thor-wl @volcano-sh-bot @william-wang