Add pytorch plugin

[ccchenjiahuan]

No description provided.

[volcano-sh-bot]

Welcome @ccchenjiahuan!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

[hwdef]

Please add some e2e test.
And add a user guide in https://github.com/volcano-sh/volcano/tree/master/docs/user-guide
This plugin doesn't seem to be registered.

volcano/pkg/controllers/job/plugins/factory.go

Line 30 in 40b7fa7

func init() {

[Thor-wl]

Thanks for your contribution! It makes sense a lot! BTW, Could you add some technology details in the design doc and a user guide under the folder

[ccchenjiahuan]

Please add some e2e test. And add a user guide in https://github.com/volcano-sh/volcano/tree/master/docs/user-guide This plugin doesn't seem to be registered.

volcano/pkg/controllers/job/plugins/factory.go

Line 30 in 40b7fa7

func init() {

thanks for the comments, l am trying to test with some examples and will come back once ready.

[ccchenjiahuan]

Thanks for your contribution! It makes sense a lot! BTW, Could you add some technology details in the design doc and a user guide under the folder

ok, l will add it

[Thor-wl]

BTW, pls execute go fmt xxx to pass the code verify.

[hwdef]

Do you have design documentation?

[ccchenjiahuan]

Do you have design documentation?

yes, I am preparing it, but there are some problems when testing pytorch example, I will upload it after all ready

[shinytang6]

/hold

[ccchenjiahuan]

Hi @hwdef @Thor-wl @shinytang6 , related comments have been added, could you help to review it again, thanks!

[ccchenjiahuan]

hi @Thor-wl , l have fixed your comments, please help rerun the ci, thanks!

[shinytang6]

/hold cancel

[shinytang6]

Please help review the PR again. @Thor-wl @hwdef

[Thor-wl]

It's generally LGTM to me now. Thanks for your contribution! Looking forward to other reviewers' advice.

[Thor-wl]

/lgtm

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Thor-wl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment