Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter the rescheduling strategies which contain victim functions #2342

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

Thor-wl
Copy link
Contributor

@Thor-wl Thor-wl commented Jul 8, 2022

fix: #2341
Signed-off-by: Thor-wl 13164644535@163.com

Signed-off-by: Thor-wl <13164644535@163.com>
@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 8, 2022
@Thor-wl Thor-wl requested review from hwdef, qiankunli, william-wang and wpeng102 and removed request for merryzhou July 8, 2022 01:42
@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wpeng102

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2022
@volcano-sh-bot volcano-sh-bot merged commit 42702f7 into volcano-sh:master Jul 8, 2022
@Thor-wl Thor-wl changed the title filter the rescheduling strategies which contain victim fucntions filter the rescheduling strategies which contain victim functions Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rescheduling strategy parse is not robust which may lead to panic
3 participants