Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable https healthz listen; #2523

Merged
merged 1 commit into from
Oct 21, 2022
Merged

enable https healthz listen; #2523

merged 1 commit into from
Oct 21, 2022

Conversation

waiterQ
Copy link
Contributor

@waiterQ waiterQ commented Oct 10, 2022 •
edited
Loading

enable healthz listen with https;

ref apis #91

@volcano-sh-bot volcano-sh-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2022
@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 10, 2022
@waiterQ waiterQ mentioned this pull request Oct 10, 2022
Closed
@jinzhejz
Copy link
Contributor

I think we need also update command line of controller/scheduler in installer/volcano-development.yaml

@waiterQ
Copy link
Contributor Author

waiterQ commented Oct 10, 2022

I think we need also update command line of controller/scheduler in installer/volcano-development.yaml

shall we use https in health-check as default? I guess we just let https be an new option.

@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2022
@waiterQ
Copy link
Contributor Author

waiterQ commented Oct 10, 2022 •
edited
Loading

I think we need also update command line of controller/scheduler in installer/volcano-development.yaml

sorry, i mistake ParseCAFiles in controller, scheduler as must-need, had fix it.

@waiterQ waiterQ force-pushed the enable-healthz-https branch 7 times, most recently from 96d82b0 to b2a0d43 Compare October 14, 2022 06:15
@waiterQ
enable https healthz listen;
5fa7001 
Signed-off-by: shaoqiu <516595344@qq.com>
@waiterQ waiterQ changed the title [WIP] enable https healthz listen; enable https healthz listen; Oct 17, 2022
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2022
william-wang
william-wang approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2022
@volcano-sh-bot volcano-sh-bot merged commit d6cf766 into volcano-sh:master Oct 21, 2022
@waiterQ waiterQ deleted the enable-healthz-https branch October 25, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@william-wang william-wang william-wang approved these changes

@hwdef hwdef Awaiting requested review from hwdef

@Yikun Yikun Awaiting requested review from Yikun

Assignees

@william-wang william-wang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waiterQ @jinzhejz @volcano-sh-bot @william-wang