Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Realias scheduling api version name in package imports #2526

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Realias scheduling api version name in package imports #2526

merged 1 commit into from
Oct 13, 2022

Conversation

kerthcet
Copy link
Member

Signed-off-by: kerthcet kerthcet@gmail.com

/kind cleanup

@volcano-sh-bot volcano-sh-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 10, 2022
@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 10, 2022
hzxuzhonghu
hzxuzhonghu approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 10, 2022
hwdef
hwdef reviewed Oct 10, 2022
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The CI seems to have a problem and needs to be fixed.

@kerthcet
Copy link
Member Author

/lgtm

The CI seems to have a problem and needs to be fixed.

@hwdef Would you mind to add a ok-to-test, I'll try to dig the root cause.

@hzxuzhonghu
Copy link
Collaborator

/ok-to-test

@volcano-sh-bot volcano-sh-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed lgtm Indicates that a PR is ready to be merged. labels Oct 11, 2022
@kerthcet kerthcet force-pushed the cleanup/remove-scheduling-api-version branch 2 times, most recently from 517e682 to b82e394 Compare October 11, 2022 16:16
hwdef
hwdef reviewed Oct 12, 2022
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits, I think it's enough to keep only two.

@hwdef
Copy link
Member

hwdef commented Oct 12, 2022

/hold

@volcano-sh-bot volcano-sh-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2022
@kerthcet kerthcet force-pushed the cleanup/remove-scheduling-api-version branch from 45fb751 to 30c0d5b Compare October 12, 2022 02:15
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kerthcet
Copy link
Member Author

It's just for testing, I raised another PR to fix this CI error here #2532. PTAL, thanks a lot.

@kerthcet
Copy link
Member Author

/retest

@kerthcet
Copy link
Member Author

@hwdef would you mind to add LGTM again. it's ready to merge now since the CI is fixed. But I have no idea how to trigger the CI test again. 🙃

@kerthcet
Realias scheduling api version name in package imports
a1fb30b 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet kerthcet force-pushed the cleanup/remove-scheduling-api-version branch from 30c0d5b to a1fb30b Compare October 13, 2022 10:50
@kerthcet
Copy link
Member Author

Repushed to trigger the CI.

hwdef
hwdef reviewed Oct 13, 2022
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel
/lgtm

@volcano-sh-bot volcano-sh-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 13, 2022
@volcano-sh-bot volcano-sh-bot merged commit 89bfc66 into volcano-sh:master Oct 13, 2022
@hwdef
Copy link
Member

hwdef commented Oct 13, 2022

@hwdef would you mind to add LGTM again. it's ready to merge now since the CI is fixed. But I have no idea how to trigger the CI test again. 🙃

The volcano's robot does not have a reset command, you can re-trigger CI by submitting it again (the same as you did), or by closing and reopening PR

@kerthcet kerthcet deleted the cleanup/remove-scheduling-api-version branch October 13, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

Assignees

@hwdef hwdef

@hzxuzhonghu hzxuzhonghu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kerthcet @hzxuzhonghu @hwdef @volcano-sh-bot