Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete redundant import alias #2675

Merged
merged 1 commit into from
Feb 13, 2023
Merged

delete redundant import alias #2675

merged 1 commit into from
Feb 13, 2023

Conversation

shoothzj
Copy link
Member

No description provided.

@volcano-sh-bot
Copy link
Contributor

Welcome @shoothzj!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 10, 2023
@shoothzj
delete redundant import alias
fc57772 
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
@shoothzj shoothzj force-pushed the delete-redundant-import-alias branch from b9848c4 to fc57772 Compare February 10, 2023 09:46
hwdef
hwdef reviewed Feb 10, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not recommended to delete v1alpha1, which should be added automatically by IDE, such as vscode, if deleted, it will be added again,

@shoothzj
Copy link
Member Author

@hwdef Thanks for your review. Let me check if later

@shoothzj
Copy link
Member Author

From I tested in vscode. It doesn't auto add v1alpha by vscode. Did I missing something?
image

@hwdef
Copy link
Member

hwdef commented Feb 12, 2023

From I tested in vscode. It doesn't auto add v1alpha by vscode. Did I missing something? image

I tested and it looks like this autofill will only fill 'v1'

v1 "k8s.io/api/core/v1"

so, this PR is great. Thank you!

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2023
@volcano-sh-bot volcano-sh-bot merged commit 625f5be into volcano-sh:master Feb 13, 2023
@shoothzj shoothzj deleted the delete-redundant-import-alias branch February 23, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@merryzhou merryzhou Awaiting requested review from merryzhou

Assignees

@hwdef hwdef

@hzxuzhonghu hzxuzhonghu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shoothzj @volcano-sh-bot @hwdef @hzxuzhonghu