-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports the collection of average indicator data for multiple time periods #2706
Supports the collection of average indicator data for multiple time periods #2706
Conversation
…eriods Signed-off-by: wangyang <wangyang8126@gmail.com>
086874b
to
b815ad9
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Shoothzj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@shoothzj: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
need to keep |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
/reopen |
@hwdef: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
Obtains the actual load data of a node from the custom metrics API. #3176 has implemented this capability. /close |
@wangyang0616: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Only 5m of data is collected in the current cache, and other time periods configured by the user in usage will not take effect.
The current PR supports collecting the average indicator data of multiple time periods in the cache, such as: 5m, 10m, 15m, 30m, 1h, 1d, the user can decide which indicator to use in the usage plugin.