Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports the collection of average indicator data for multiple time periods #2706

Conversation

wangyang0616
Copy link
Member

Only 5m of data is collected in the current cache, and other time periods configured by the user in usage will not take effect.

The current PR supports collecting the average indicator data of multiple time periods in the cache, such as: 5m, 10m, 15m, 30m, 1h, 1d, the user can decide which indicator to use in the usage plugin.

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 25, 2023
…eriods

Signed-off-by: wangyang <wangyang8126@gmail.com>
@wangyang0616 wangyang0616 force-pushed the feature_multiple_sampling_periods branch from 086874b to b815ad9 Compare February 25, 2023 07:55
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shoothzj
To complete the pull request process, please assign k82cn
You can assign the PR to them by writing /assign @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot
Copy link
Contributor

@shoothzj: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@stale
Copy link

stale bot commented May 1, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2023
@wangyang0616
Copy link
Member Author

need to keep

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 4, 2023
@stale
Copy link

stale bot commented Aug 7, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2023
@stale stale bot closed this Sep 17, 2023
@hwdef
Copy link
Member

hwdef commented Sep 17, 2023

/reopen

@volcano-sh-bot
Copy link
Contributor

@hwdef: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lowang-bh
Copy link
Member

/lgtm

@stale stale bot removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 17, 2023
@wangyang0616
Copy link
Member Author

Obtains the actual load data of a node from the custom metrics API. #3176 has implemented this capability.

/close

@volcano-sh-bot
Copy link
Contributor

@wangyang0616: Closed this PR.

In response to this:

Obtains the actual load data of a node from the custom metrics API. #3176 has implemented this capability.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants