-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pod admission mutate patch affinity #2737
Conversation
8ea649d
to
7e9062b
Compare
7e9062b
to
1cf8fbd
Compare
d680dac
to
1cf8fbd
Compare
/ok-to-test |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the background of this function
We want to use more rich affinity configurations to control pod allocation, which may not only be node selection. In case of insufficient machines, we can occupy cluster resources of other services. |
Sorry I still don't understand the scenario, please be more specific or give an example, thanks |
Signed-off-by: min.jia <jiamin13579@126.com> Signed-off-by: min.jia <jiamin13579@126.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I just restarted the ci. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Admission pods, resourceGroups support mutate patch pod affinity. The format is a json string.
volcano-admission.conf example