Refactor namespace fairshare function. #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/XL
jinzhejz
reviewed
Mar 29, 2023
| queueMap = make(map[api.QueueID]*util.PriorityQueue) | ||
| jobsMap[namespace] = queueMap | ||
| } | ||
| queues.Push(ssn.Queues[job.Queue]) |
There was a problem hiding this comment.
It seems that it will push duplicate queues to queues
There was a problem hiding this comment.
Yes, queue should be pushed in queues only on the first job in the queue is picked. I'll modify it, thank you.
Signed-off-by: jiangkaihua <jiangkaihua1@huawei.com>
jiangkaihua
force-pushed
the
refactor-namespace-fairshare
branch
from
2df8d0c
to
4ee689a
Compare
william-wang
requested review from
william-wang and
elinx
and removed request for
kevin-wangzefeng and
k82cn
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
allocateaction must sortnamespace, thenqueuein each namespace, then jobs in a queue of single namespace, which is time-costing and inefficient, just to realizenamespace-fairshare. And, sinceallocateaction worked differently withpreemptandreclaimaction, it kept causing comlicated issues inevictand re-allocate in next session. So I would rather realizenamespace-fairshareby other methods instead of sort namespaces inallocateaction.