fix synchronous pvc/pv bind error when volcano schedule pod with pvc #2844
Conversation
volcano-sh-bot
added
the
size/M
| return | ||
| } | ||
| bindTasks := make([]*schedulingapi.TaskInfo, len(successfulTasks)) | ||
| copy(bindTasks, successfulTasks) |
There was a problem hiding this comment.
Please replace the extra tab with two spaces, which may be better，because the tab size settings vary among different editors
There was a problem hiding this comment.
ok, I should have solved this problem 。
There was a problem hiding this comment.
Please replace the extra tab with two spaces, which may be better，because the tab size settings vary among different editors
volcano uses tabs if you take a close look at the code🤣
gj409237405
force-pushed
the
fixSynchronousBindError
branch
2 times, most recently
from
a2c5a5c
to
2e10433
Compare
pkg/scheduler/cache/cache.go
Outdated
| sc.VolumeBinder.RevertVolumes(task, task.PodVolumes) | ||
| sc.resyncTask(task) | ||
| } | ||
| func (sc *SchedulerCache) Bind(taskArray []*schedulingapi.TaskInfo) error { |
There was a problem hiding this comment.
What is the reason for Volcano's original asynchronous binding, performance?
Does the modification to synchronous have any impact on performance?
There was a problem hiding this comment.
ok,here The reason which change asynchronous to synchronous is I have move the asynchronous to above little , so here is not need
gj409237405
force-pushed
the
fixSynchronousBindError
branch
8 times, most recently
from
4fec262
to
f6098be
Compare
pkg/scheduler/cache/cache.go
Outdated
| } else { | ||
| successfulTasks = append(successfulTasks, task) | ||
| klog.V(5).Infof("task %s/%s bind Volumes done", task.Namespace, task.Name) | ||
| func (sc *SchedulerCache) BindTask(bindCache []*schedulingapi.TaskInfo) { |
There was a problem hiding this comment.
why we have to add bindcache parameter.
|
@gj199575 please enable the batch bind and have a test. |
pkg/scheduler/cache/cache.go
Outdated
| klog.V(5).Infof("batch bind task count %d", len(bindCache)) | ||
| var tmpBindCache []*schedulingapi.TaskInfo = make([]*schedulingapi.TaskInfo, len(bindCache)) | ||
| copy(tmpBindCache, bindCache) | ||
| go func(bindCacheParam []*schedulingapi.TaskInfo, sc *SchedulerCache) { |
There was a problem hiding this comment.
suggest change bindCacheParam to tasks
Signed-off-by: gj199575 <409237405@qq.com>
gj409237405
force-pushed
the
fixSynchronousBindError
branch
from
f6098be
to
7223f96
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
this pr solve #2843