-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use one helm command to install resource #2985
Conversation
/assign @wangyang0616 @hwdef @william-wang |
Signed-off-by: lowang-bh <lhui_wang@163.com>
/priority important-soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @Thor-wl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think this pr can cherry-pick to the release-1.8 branch. @lowang-bh |
Have opened an PR. Plese help to review #3017 |
use one command to install helm resource with sub charts, there are mainly two benefit:
helm install volcano installer/helm/chart/volcano --namespace volcano-system --create-namespace
), such as kubeflowIn the future, if there are more subcharts, just
installer/helm/chart/volcano/charts/
installer/helm/chart/volcano/Chart.yaml
Relative PRs: #2882, #2936