Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support dump scheduler cache snapshot to json file #3162

Merged
merged 1 commit into from
Feb 2, 2024
Merged

support dump scheduler cache snapshot to json file #3162

merged 1 commit into from
Feb 2, 2024

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented Oct 22, 2023 •
edited
Loading

Fixes #3154

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 22, 2023
hwdef
hwdef reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of them are fine.

I think it would be best if we could specify the output location of the file via the parameter

@lowang-bh
Copy link
Member Author

Test results.
image

@lowang-bh
Copy link
Member Author

I think it would be best if we could specify the output location of the file via the parameter

Done。
image

hwdef
hwdef reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@lowang-bh
Copy link
Member Author

re-trigger CI

@lowang-bh lowang-bh closed this Oct 23, 2023
@lowang-bh lowang-bh reopened this Oct 23, 2023
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
hwdef
hwdef reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
@lowang-bh
Copy link
Member Author

/assign @wangyang0616 @hwdef

@hwdef
Copy link
Member

hwdef commented Dec 4, 2023

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
@Monokaix
Copy link
Member

Monokaix commented Dec 8, 2023

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
@lowang-bh lowang-bh mentioned this pull request Dec 11, 2023
Closed
@Monokaix
Copy link
Member

Hi, please squash and remove merged commit, and split the commit into fixing unmarshal err and support dump scheduler cache snapshot to json file.

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
@lowang-bh
Copy link
Member Author

Hi, please squash and remove merged commit, and split the commit into fixing unmarshal err and support dump scheduler cache snapshot to json file.

Done.

Monokaix
Monokaix reviewed Dec 15, 2023
View reviewed changes
Copy link
Member

@Monokaix Monokaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@Monokaix
Copy link
Member

Hi, the issue mentioned about marsh error seems serious, so can you split it to a single pr so we can backport it to previous relase.

@lowang-bh lowang-bh mentioned this pull request Dec 18, 2023
Merged
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023
@lowang-bh
support dump scheduler cache snapshot to json file
111d3a1 
Signed-off-by: lowang-bh <lhui_wang@163.com>
@lowang-bh
Copy link
Member Author

image

@lowang-bh
Copy link
Member Author

Any questions ? @Monokaix @william-wang

@Monokaix
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
william-wang
william-wang approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
@volcano-sh-bot volcano-sh-bot merged commit 33953ef into volcano-sh:master Feb 2, 2024
13 checks passed
@lowang-bh lowang-bh deleted the sigUser1 branch February 2, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@Monokaix Monokaix Monokaix left review comments

@william-wang william-wang william-wang approved these changes

@hudson741 hudson741 Awaiting requested review from hudson741

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@william-wang william-wang

@hwdef hwdef

@Monokaix Monokaix

@wangyang0616 wangyang0616

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dump scheduler snapshot into local file in a format that is easy to parse
6 participants
@lowang-bh @hwdef @Monokaix @volcano-sh-bot @william-wang @wangyang0616