Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license lint check #3308

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Add license lint check #3308

merged 1 commit into from
Jan 22, 2024

Conversation

Monokaix
Copy link
Member

@Monokaix Monokaix commented Jan 22, 2024

issue: #3309

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 22, 2024
@Monokaix Monokaix force-pushed the license branch 2 times, most recently from 4a15c8d to 6cb5dbb Compare January 22, 2024 09:31
@volcano-sh-bot volcano-sh-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2024
@Monokaix Monokaix force-pushed the license branch 2 times, most recently from d3610a3 to 1b0072e Compare January 22, 2024 11:19
Signed-off-by: Xuzheng Chang <changxuzheng@huawei.com>
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@volcano-sh-bot volcano-sh-bot merged commit dec5b02 into volcano-sh:master Jan 22, 2024
14 checks passed
@wangyang0616
Copy link
Member

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@Monokaix Monokaix deleted the license branch January 23, 2024 01:36
@william-wang william-wang added this to the v1.9 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants