Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maxRetry in job controller to prevent endless loop #412

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Add maxRetry in job controller to prevent endless loop #412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94d9c56
Add maxRetry in job controller to prevent endless loop
hzxuzhonghu Aug 12, 2019
490ba7b
Add event
hzxuzhonghu Aug 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions pkg/controllers/job/job_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,15 @@ import (
"volcano.sh/volcano/pkg/controllers/job/state"
)

const (
// maxRetries is the number of times a volcano job will be retried before it is dropped out of the queue.
// With the current rate-limiter in use (5ms*2^(maxRetries-1)) the following numbers represent the times
// a volcano job is going to be requeued:
//
// 5ms, 10ms, 20ms, 40ms, 80ms, 160ms, 320ms, 640ms, 1.3s, 2.6s, 5.1s, 10.2s, 20.4s, 41s, 82s
maxRetries = 15
)

// Controller the Job Controller type
type Controller struct {
kubeClients kubernetes.Interface
Expand Down Expand Up @@ -312,11 +321,16 @@ func (cc *Controller) processNextReq(count uint32) bool {
}

if err := st.Execute(action); err != nil {
glog.Errorf("Failed to handle Job <%s/%s>: %v",
jobInfo.Job.Namespace, jobInfo.Job.Name, err)
// If any error, requeue it.
queue.AddRateLimited(req)
return true
if queue.NumRequeues(req) < maxRetries {
glog.V(2).Infof("Failed to handle Job <%s/%s>: %v",
jobInfo.Job.Namespace, jobInfo.Job.Name, err)
// If any error, requeue it.
queue.AddRateLimited(req)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update job status and record events accordingly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

job status and event inside of the Execute function should be enough for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's kind of event in Execute? How user identify whether it's done?

return true
}
cc.recordJobEvent(jobInfo.Job.Namespace, jobInfo.Job.Name, vkbatchv1.ExecuteAction, fmt.Sprintf(
"Job failed on action %s for retry limit reached", action))
glog.Warningf("Dropping job<%s/%s> out of the queue: %v because max retries has reached", jobInfo.Job.Namespace, jobInfo.Job.Name, err)
}

// If no error, forget it.
Expand Down