Queue refactor. #445
Merged
Queue refactor. #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Klaus Ma <klaus1982.cn@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
approved
hzxuzhonghu
reviewed
Sep 12, 2019
| c.pgMutex.RUnlock() | ||
| glog.V(2).Infof("queue %s has not been seen or deleted", key) | ||
| return nil | ||
| return nil, fmt.Errorf("queue %s has not been seen or deleted", key) |
There was a problem hiding this comment.
It is dangerous, think a queue is deleted before a pg. It will cause endless retry.
There was a problem hiding this comment.
let's handle this in different PR, refer to the TODO in following codes :)
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Klaus Ma klaus1982.cn@gmail.com