Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup e2e framework to speed up e2e #588

Merged
merged 3 commits into from
Dec 9, 2019
Merged

Cleanup e2e framework to speed up e2e #588

merged 3 commits into from
Dec 9, 2019

Conversation

hzxuzhonghu
Copy link
Collaborator

Remove unneccessary queue and priorityclass creation

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 6, 2019
@k82cn
Copy link
Member

k82cn commented Dec 6, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 6, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 5f4bda00-17fe-11ea-95f4-abb8efddad88

@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: b6e132e0-1800-11ea-95f4-abb8efddad88

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2019
@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 064f4440-1a52-11ea-8ac4-55ffd8dc6fb9

@hzxuzhonghu
Copy link
Collaborator Author

The CI now takes 40minutes, saved 7-8 minutes.

@k82cn
Copy link
Member

k82cn commented Dec 9, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit cbe3c00 into volcano-sh:master Dec 9, 2019
@hzxuzhonghu hzxuzhonghu deleted the e2e-framework branch December 9, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@quinton-hoole quinton-hoole Awaiting requested review from quinton-hoole

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hzxuzhonghu @k82cn @TravisBuddy @volcano-sh-bot