Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update job_controller_util.go #625

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Conversation

YesterdayxD
Copy link
Contributor

remove repeated code .
Line 94-64 exists same code.

remove repeated code .
Line 94-64 exists same code.
@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 19, 2019
@hzxuzhonghu
Copy link
Collaborator

Thanks @YesterdayxD

/lgtm

/appove

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2019
@k82cn
Copy link
Member

k82cn commented Dec 19, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, YesterdayxD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2019
@TravisBuddy
Copy link

Hey @YesterdayxD,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: ef4b9420-222a-11ea-b76a-c509dfe0ae07

@volcano-sh-bot volcano-sh-bot merged commit d3bfe0b into volcano-sh:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants