Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated check in jobEnqueueableFn of proportion #638

Merged
merged 1 commit into from
Dec 25, 2019

Conversation

zionwu
Copy link
Contributor

@zionwu zionwu commented Dec 25, 2019

In jobEnqueueableFn of proportion plugin, the following check is duplicated:

    	if len(queue.Queue.Spec.Capability) == 0 

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 25, 2019
@k82cn
Copy link
Member

k82cn commented Dec 25, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 25, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, zionwu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 25, 2019
return true
}

pgResource := api.NewResource(*job.PodGroup.Spec.MinResources)
if len(queue.Queue.Spec.Capability) == 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and it seems we did not add capability into crds :(

@TravisBuddy
Copy link

Hey @zionwu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 081da6c0-26f7-11ea-9fe8-03452f69915b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants