Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Shareit as one of adopter #670

Merged
merged 1 commit into from
Jan 19, 2020
Merged

Added Shareit as one of adopter #670

merged 1 commit into from
Jan 19, 2020

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Jan 19, 2020

xref #308

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 19, 2020
@k82cn
Copy link
Member Author

k82cn commented Jan 19, 2020

/cc @yujiantao

xref #308 (comment)

@volcano-sh-bot
Copy link
Contributor

@k82cn: GitHub didn't allow me to request PR reviews from the following users: yujiantao.

Note that only volcano-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yujiantao

xref #308 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hzxuzhonghu
Copy link
Collaborator

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2020
@volcano-sh-bot volcano-sh-bot merged commit 2d7766d into master Jan 19, 2020
@volcano-sh-bot volcano-sh-bot deleted the shareit-adopter branch January 19, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hex108 hex108 Awaiting requested review from hex108

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees

@hzxuzhonghu hzxuzhonghu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k82cn @volcano-sh-bot @hzxuzhonghu