Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure TODO item: add a flag to disable Network Policy #722

Merged
merged 3 commits into from
Feb 28, 2020
Merged

Figure TODO item: add a flag to disable Network Policy #722

merged 3 commits into from
Feb 28, 2020

Conversation

EDGsheryl
Copy link
Contributor

usage: add the args in the job yaml

plugins:
svc: ["--disable-network-policy=true"]

I have tested it. However, I am wondering there is somewhere for me to add a unit test? Please let me know if you want an unit test.

@volcano-sh-bot
Copy link
Contributor

Welcome @EDGsheryl!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 27, 2020
hzxuzhonghu
hzxuzhonghu reviewed Feb 27, 2020
View reviewed changes
Copy link
Collaborator

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

A ut is better

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2020
@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2020
@TravisBuddy
Copy link

Hey @EDGsheryl,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: b310c600-5953-11ea-822e-0bf67ba4204b

@k82cn
Copy link
Member

k82cn commented Feb 28, 2020

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EDGsheryl, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2020
@volcano-sh-bot volcano-sh-bot merged commit ed6b56b into volcano-sh:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu left review comments

@quinton-hoole quinton-hoole Awaiting requested review from quinton-hoole

Assignees

@hzxuzhonghu hzxuzhonghu

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EDGsheryl @volcano-sh-bot @TravisBuddy @k82cn @hzxuzhonghu