[controller] Set BlockOwnerDeletion to true when create PodGroup

[xiaogaozi]

Fix #755

[xiaogaozi]

/assign @hzxuzhonghu

[hzxuzhonghu]

/lgtm

[hzxuzhonghu]

nit: Instead of constructing this one by one. Can use metav1.NewControllerRef function.

[xiaogaozi]

Good suggestion! I've updated the PR.

[hzxuzhonghu]

@xiaogaozi The ut failed

=== RUN   TestAddPodGroup
--- FAIL: TestAddPodGroup (0.00s)
    pg_controller_test.go:157: Case AddPodGroup: pod has no ownerReferences or priorityClassName failed, expect &{{PodGroup scheduling.volcano.sh/v1beta1} {podgroup-7a09885b-b753-4924-9fba-77c0836bac20  test    0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [{v1 Pod pod1 7a09885b-b753-4924-9fba-77c0836bac20 0xc000046250 <nil>}] []  []} {1   <nil>} { [] 0 0 0}}, got &{{ } {podgroup-7a09885b-b753-4924-9fba-77c0836bac20  test    0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [{v1 Pod pod1 7a09885b-b753-4924-9fba-77c0836bac20 0xc0000462b1 0xc0000462b2}] []  []} {1   <nil>} { [] 0 0 0}}
FAIL

[hzxuzhonghu]

/lgtm

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, xiaogaozi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controllers/OWNERS [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[TravisBuddy]

Hey @xiaogaozi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 47464dd0-7598-11ea-b60d-a5b03af48ea2