Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Seihon for multi arch #817

Merged
merged 4 commits into from
Sep 29, 2020
Merged

Add Seihon for multi arch #817

merged 4 commits into from
Sep 29, 2020

Conversation

StefanSchoof
Copy link
Contributor

Resolves #746

First test if Seihorn is in path on Travis

@StefanSchoof
Copy link
Contributor Author

@andig Ich verstehe gerade nicht warum ich das seihorn --version keine Ausgabe in dem Travis Log hinterlässt. Hast du eine Idee was da los ist?

@andig
Copy link
Contributor

andig commented Aug 16, 2020

Da isser: https://travis-ci.org/github/volkszaehler/volkszaehler.org/jobs/718347334#L350

@StefanSchoof StefanSchoof marked this pull request as ready for review August 16, 2020 18:02
@StefanSchoof
Copy link
Contributor Author

Danke, ich habe nach Seihorn (mit r) gesucht ...

@StefanSchoof
Copy link
Contributor Author

Is there anything I can do to get this merged?

andig
andig requested changes Sep 27, 2020
View reviewed changes
.travis.yml Outdated
docker pull $REPO:latest
docker build --cache-from $REPO:latest -f Dockerfile -t $REPO:latest .
docker push $REPO
seihon publish -v seihorn --image-name $REPO --base-runtime-image php:7.3-alpine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was soll das -v bedeuten?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weiß ich nicht mehr. Aber wenn ich mir jetzt andere Befehle anschaue, denke ich das ich das es falsch ist

@andig
Copy link
Contributor

andig commented Sep 27, 2020 •
edited
Loading

Sorry, mir war nicht klar, dass das fertig ist. Hast Du mal die Größe von altem und neuem Image verglichen? Wäre es evtl möglich den php-builder Teil noch in die Build Stage zu verlagern? Das dürfte mit einer kompletten Build Umgebung ziemlich groß sein?

@r00t- r00t- changed the title Add Seihorn for multi arch Add Seihon for multi arch Sep 27, 2020
@andig
Copy link
Contributor

andig commented Sep 29, 2020

LGTM- could you confirm that the multi-arch build actually succeeds?

@StefanSchoof
Copy link
Contributor Author

I published this to https://hub.docker.com/layers/stefanschoof/volkszaehler/seihorn/images/sha256-e316bf40ca6180f9cd45fc0d0769afa4a5debc40781b129505d61f7d93c28fe3 and running this without problems currently on my zero.

Because of docker/for-linux#1025 I had only to activate experimental features, to be able to use the platform flag at the pull command. (docker pull --platform linux/arm/v6 stefanschoof/volkszaehler:seihorn)

@andig andig merged commit 906018b into volkszaehler:master Sep 29, 2020
@andig
Copy link
Contributor

andig commented Sep 29, 2020

Klasse- damit haben wir jetzt multi-arch, vielen Dank für den PR!

@StefanSchoof StefanSchoof mentioned this pull request Sep 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andig andig andig requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create ARM docker image
2 participants
@StefanSchoof @andig