Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlnx-fw-upgrade] Add FW reactivation in case 2 FW upgrades were done… #13

Closed
wants to merge 1 commit into from

Conversation

volodymyrsamotiy
Copy link
Owner

@volodymyrsamotiy volodymyrsamotiy commented Oct 24, 2023

… without reboot

Why I did it

In order to activate FW after it was upgraded need to perform reboot.
If reboot wasn't performed and user need to upgrade to another SONiC image then it will fail.
The reason for that is that during SONiC upgrade new FW should be installed but it will fail because previously installed FW wasn't activated.
In order to allow 2nd FW upgrade without reboot in-between need to reactivate FW image.
This change handles such flow.

Example of issue scenario:

  • User installed SONiC image on the switch
  • Then for some reason FW was upgraded by user or script but reboot was not performed to activate it.
  • After that upgrade to new SONiC image will fail because new image need to install FW but it fails due to previous one wasn't activated.
Work item tracking
  • Microsoft ADO (number only):

How I did it

In "mlnx-fw-upgrade" script check if FW upgrade failed with the error that FW was already installed but reboot was not performed.
If so then perform FW image reactivation and try to upgrade FW again.

How to verify it

  • Install SONiC image on the switch
  • Then upgrade FW but don't perform reboot.
  • After that upgrade to new SONiC image and check that upgrade was successfull.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

[mlnx-fw-upgrade] Add FW reactivation in case 2 FW upgrades were done without reboot

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

… without reboot

Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant