137-consent-prompt-for-video-embed-block

[luukbrauckmann]

Changes

• Adds consent alert to VideoEmbedBlock

Associated issue

Resolves #137

How to test

1. Open preview link
2. Scroll down to the Video
3. Click on the video
4. There should be an overlay popping up asking for permission
5. Click the allow button.
6. Video should start.
7. Check if this permission is added in the local storage.

Checklist

• I have performed a self-review of my own code
• I have made sure that my PR is easy to review (not too big, includes comments)
• I have made updated relevant documentation files (in project README, docs/, etc)
• I have added a decision log entry if the change affects the architecture or changes a significant technology
• I have notified a reviewer

[cloudflare-workers-and-pages]

Deploying head-start with    Cloudflare Pages

Latest commit:	cc2638d
Status:	✅  Deploy successful!
Preview URL:	https://bfbf6b0f.head-start.pages.dev
Branch Preview URL:	https://137-consent-prompt-for-video.head-start.pages.dev

View logs

[luukbrauckmann]

I could pretty easily copy all the code from the nododos project, because it's pretty generic.

[luukbrauckmann]

Readme already contained an item about the consent alert

[jbmoelker]

👏👏. We should do the same for the Embed Block, but probably in a new PR :)

[decrek]

Why do we store the user's choice in local storage and not in a cookie? If we would do server side rendering we could render/not render the cookie preferences. I understand that that doesnt make sense for the video embed, but for cookie cookie preferences in general I would like a solution that saves the preferences in a cookie

[jbmoelker]

👏👏. We should do the same for the Embed Block, but probably in a new PR :)

See #157