Adding plotly v5 support! #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1099
Resolves #1319
This PR removes the
plotly<5restriction that exists in FiftyOne's current dependencies (currently we requireplotly>=4.14,<5).After doing some digging, it turns out this small regression introduced in
plotly==5.0.0was breaking the selection callbacks of our interactive plots.The plotly maintainers patched this regression in plotly==5.2.1, so this PR could have just updated our dependency to
plotly>=5.2.1. However, it was simple to patch the regression and thus supportplotly>=4.14.I also added a
jupyterlab>=3requirement to the recommended JupyterLab setup instructions in the docs, which simplifies the install process.This PR was tested by manually running these two examples in Jupyter notebooks and JupyterLab: