ssh.keep_alive: Add option to add the ssh keep alive option #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
changed the title
|
There's a typo in the commit message: |
We have an issue where sometimes the ssh connection is killed. this happens due to puppet changing the sshd keep alive settings while beaker is still running. This patch adds the ability for users to add ssh_keep_alive to the host config to ensure we send keep alive packets every 5 seconds
fixed |
bastelfreak
reviewed
Aug 29, 2024
| @@ -53,6 +53,7 @@ def make_vfile(hosts, options = {}) | |||
| hosts.each do |host| | |||
| host.name.tr!('_', '-') # Rewrite Hostname with hyphens instead of underscores to get legal hostname | |||
| set_host_default_ip(host) | |||
| v_file << " c.ssh.keep_alive = true\n" if host['ssh_keep_alive'] == true | |||
There was a problem hiding this comment.
oh that's neat. I'm wondering if we should enable it by default/always?
There was a problem hiding this comment.
Personally i think it would be a safe enough change to make this the default but will wait to see if others have a view
kenyon
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an issue where sometimes the ssh connection is killed. this happens due to puppet changing the sshd keep alive settings while beaker is still running.
This patch adds the ability for users to add ssh_keep_alive to the host config to ensure we send keep alive packets every 5 seconds