[tahaa.k] removing validate_boolean abd using inbuilt puppet datatype

voxpupuli · Nov 3, 2017 · 9b7b22f · 9b7b22f
1 parent f58077e
commit 9b7b22f
Showing 1 changed file with 24 additions and 28 deletions.
diff --git a/manifests/mesos_exporter.pp b/manifests/mesos_exporter.pp
@@ -75,36 +75,32 @@
 #  [*version*]
 #  The binary release version
 class prometheus::mesos_exporter (
-  $arch                 = $::prometheus::params::arch,
-  $bin_dir              = $::prometheus::params::bin_dir,
-  $server_type          = $::prometheus::params::mesos_exporter_server_type,
-  $cnf_scrape_uri       = $::prometheus::params::mesos_exporter_cnf_scrape_uri,
-  $download_extension   = $::prometheus::params::mesos_exporter_download_extension,
-  $download_url         = undef,
-  $download_url_base    = $::prometheus::params::mesos_exporter_download_url_base,
-  $extra_groups         = $::prometheus::params::mesos_exporter_extra_groups,
-  $extra_options        = '',
-  $group                = $::prometheus::params::mesos_exporter_group,
-  $init_style           = $::prometheus::params::init_style,
-  $install_method       = $::prometheus::params::install_method,
-  $manage_group         = true,
-  $manage_service       = true,
-  $manage_user          = true,
-  $os                   = $::prometheus::params::os,
-  $package_ensure       = $::prometheus::params::mesos_exporter_package_ensure,
-  $package_name         = $::prometheus::params::mesos_exporter_package_name,
-  $purge_config_dir     = true,
-  $restart_on_change    = true,
-  $service_enable       = true,
-  $service_ensure       = 'running',
-  $user                 = $::prometheus::params::mesos_exporter_user,
-  $version              = $::prometheus::params::mesos_exporter_version,
+$arch                           = $::prometheus::params::arch,
+  $bin_dir                      = $::prometheus::params::bin_dir,
+  $server_type                  = $::prometheus::params::mesos_exporter_server_type,
+  $cnf_scrape_uri               = $::prometheus::params::mesos_exporter_cnf_scrape_uri,
+  $download_extension           = $::prometheus::params::mesos_exporter_download_extension,
+  $download_url                 = undef,
+  $download_url_base            = $::prometheus::params::mesos_exporter_download_url_base,
+  $extra_groups                 = $::prometheus::params::mesos_exporter_extra_groups,
+  $extra_options                = '',
+  $group                        = $::prometheus::params::mesos_exporter_group,
+  $init_style                   = $::prometheus::params::init_style,
+  $install_method               = $::prometheus::params::install_method,
+  $manage_group                 = true,
+  Boolean $manage_service       = true,
+  Boolean $manage_user          = true,
+  $os                           = $::prometheus::params::os,
+  $package_ensure               = $::prometheus::params::mesos_exporter_package_ensure,
+  $package_name                 = $::prometheus::params::mesos_exporter_package_name,
+  Boolean $purge_config_dir     = true,
+  Boolean $restart_on_change    = true,
+  $service_enable               = true,
+  $service_ensure               = 'running',
+  $user                         = $::prometheus::params::mesos_exporter_user,
+  $version                      = $::prometheus::params::mesos_exporter_version,
 ) inherits prometheus::params {
   $real_download_url    = pick($download_url,"${download_url_base}/download/v${version}/${package_name}-${version}.${os}-${arch}.${download_extension}")
-  validate_bool($purge_config_dir)
-  validate_bool($manage_user)
-  validate_bool($manage_service)
-  validate_bool($restart_on_change)
   $notify_service = $restart_on_change ? {
     true    => Service['mesos_exporter'],
     default => undef,