Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Promtool #31

Closed
lswith opened this issue Dec 13, 2016 · 3 comments · Fixed by #122
Closed

Install Promtool #31

lswith opened this issue Dec 13, 2016 · 3 comments · Fixed by #122
Labels
enhancement New feature or request

Comments

@lswith
Copy link
Contributor

lswith commented Dec 13, 2016

We should install the promtool so that configuration can be checked before reloading the service.

./promtool -help
usage: promtool <command> [<args>]

Available commands:
  check-config    validate configuration files for correctness
  check-rules     validate rule files for correctness
  help            prints this help text
  version         print the version of this binary
@brutus333
Copy link
Collaborator

Only a link should be sufficient since the promtool is already in the prometheus binary distribution. On my systems I found it on /opt/staging/prometheus-${version}.linux-amd64/

@lswith
Copy link
Contributor Author

lswith commented Dec 14, 2016

that is correct. I was thinking more if we should run it before we restart the service?

@brutus333
Copy link
Collaborator

I believe we can run it before reloading or restarting the service. It may be a good idea. However, it will complicate a bit the startup scripts.

roidelapluie pushed a commit that referenced this issue Jun 21, 2017
Reload Prometheus service instead of restarting
@tuxmea tuxmea added the enhancement New feature or request label Nov 1, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this issue Aug 28, 2019
Reload Prometheus service instead of restarting
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this issue May 5, 2021
Reload Prometheus service instead of restarting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants