Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Node Exporter Collectors #33

Closed
lswith opened this issue Dec 14, 2016 · 1 comment · Fixed by #72
Closed

Default Node Exporter Collectors #33

lswith opened this issue Dec 14, 2016 · 1 comment · Fixed by #72

Comments

@lswith
Copy link
Contributor

lswith commented Dec 14, 2016

The node exporter has updated and has decent defaults. We should change the params to simply not specify any collectors as the default.
@brutus333
Copy link
Collaborator

Nice idea. I'll take it into account at the next release.

roidelapluie pushed a commit that referenced this issue Jun 21, 2017
@bastelfreak
Merge pull request #33 from martin-koerner/master
00328b9 
Add service_name param to alertmanager class
@sathieu sathieu mentioned this issue Aug 1, 2017
Merged
This was referenced Oct 18, 2017
Closed
Merged
knackjax pushed a commit to knackjax/puppet-prometheus that referenced this issue Nov 21, 2017
@TheMeier @knackjax
node_exporter 0.15.0 compatibiity
6c6e89e 
fixes voxpupuli#70
fixes voxpupuli#33

change collector parameterization to be compatible with node_exporter 0.15.0

this should be released with a major version since it breaks paramter compatinbility

for two step migration of profiles and roles using this keep node_exporter::collectors paramter as noop with deprecation warning for at least one release
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this issue Aug 28, 2019
@bastelfreak
Merge pull request voxpupuli#33 from martin-koerner/master
6adc66d 
Add service_name param to alertmanager class
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this issue Aug 28, 2019
@TheMeier
node_exporter 0.15.0 compatibiity
187447a 
fixes voxpupuli#70
fixes voxpupuli#33

change collector parameterization to be compatible with node_exporter 0.15.0

this should be released with a major version since it breaks paramter compatinbility

for two step migration of profiles and roles using this keep node_exporter::collectors paramter as noop with deprecation warning for at least one release
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this issue May 5, 2021
@bastelfreak
Merge pull request voxpupuli#33 from martin-koerner/master
8d80752 
Add service_name param to alertmanager class
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this issue May 5, 2021
@TheMeier
node_exporter 0.15.0 compatibiity
726c32d 
fixes voxpupuli#70
fixes voxpupuli#33

change collector parameterization to be compatible with node_exporter 0.15.0

this should be released with a major version since it breaks paramter compatinbility

for two step migration of profiles and roles using this keep node_exporter::collectors paramter as noop with deprecation warning for at least one release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

node_exporter 0.15.0 compatibiity
2 participants
@lswith @brutus333