Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 3.1.0 #115

Merged
merged 1 commit into from
Nov 26, 2017
Merged

release 3.1.0 #115

merged 1 commit into from
Nov 26, 2017

Conversation

bastelfreak
Copy link
Member

No description provided.

Copy link
Member

@alexjfisher alexjfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptance test failures suggest there really is a problem. I think holding off pushing a new release until the issue is resolved or at least understood is best.

@bastelfreak
Copy link
Member Author

@tuxmea I won't have time to look into this in the next days. You think you've any chance to do it?

@tuxmea
Copy link
Member

tuxmea commented Nov 22, 2017

I first have to implement the postgres_exporter (work paid by customer) - then I can look into failing tests.

@tuxmea
Copy link
Member

tuxmea commented Nov 23, 2017

I am able to reproduce the rror running the travis tests locally: rvm use 2.4.2 bundle install --path vendor and then: PUPPET_INSTALL_TYPE=agent BEAKER_debug=true BEAKER_set=docker/ubuntu-16.04 bundle exec rake beaker

Test were OK on first run and produced the service prometheus starting on the second run.

tuxmea pushed a commit to tuxmea/puppet-prometheus that referenced this pull request Nov 24, 2017
restart on-failure did not work, as prometheus just did not start
properly.
setting restart to always.

fixes voxpupuli#114
needed for voxpupuli#115
@bastelfreak
Copy link
Member Author

Addressed concerns from @alexjfisher

@bastelfreak bastelfreak merged commit b096b82 into master Nov 26, 2017
@bastelfreak bastelfreak deleted the rel310 branch November 26, 2017 11:57
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this pull request Aug 28, 2019
restart on-failure did not work, as prometheus just did not start
properly.
setting restart to always.

fixes voxpupuli#114
needed for voxpupuli#115
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this pull request Aug 28, 2019
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
restart on-failure did not work, as prometheus just did not start
properly.
setting restart to always.

fixes voxpupuli#114
needed for voxpupuli#115
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants