Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to config changes #122

Merged
merged 4 commits into from
Jan 4, 2018
Merged

Add validation to config changes #122

merged 4 commits into from
Jan 4, 2018

Commits on Jan 4, 2018

  1. add symlink to promtool

    @costela
    costela committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    cb754ba View commit details
    Browse the repository at this point in the history

  2. verify config before replacing

    @costela
    costela committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    766f1df View commit details
    Browse the repository at this point in the history

  3. also add check to rules file; centralize $alertfile_name in params

    @costela
    costela committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    081fbca View commit details
    Browse the repository at this point in the history

  4. move config_dir creation to install.pp 

    This is needed to break a dependency cycle involving alert.rules and the main config.

Minor breaking change: if anyone used the purge argument directly to prometheus::config (instead of the prometheus class itself), the call will have to be adjusted.
    @costela
    costela committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    15fca55 View commit details
    Browse the repository at this point in the history