-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding remote_write support #144
Conversation
Looks good to me. Can you add spec tests for the new parameter? |
Yes. But I am missing a test for the parameter, like: https://github.com/voxpupuli/puppet-prometheus/blob/master/spec/classes/prometheus_spec.rb#L203 |
Here I need some help , Cause read parameter is also missing tests, maybe someone can help me to write this tests? |
Busy today. I can provide a test within tomorrow. |
Thank you ! |
Fix syntax at the end of remote_read and remote_write
Another pull is included , support for alertmanager 0.13.0 see https://github.com/prometheus/alertmanager/releases/tag/v0.13.0 |
Thanks. In future: Please keep separate issues in separate PR. |
@kalinux please find the following patch for spec:
|
Hi @tuxmea , Please review code. BR |
Thank you.
|
So how is this can be solved ? 🤔 |
@kalinux Try to run check tests prior pushing your changes. For workstation setup you can read on example42 blog developer setup and have a look at the puppet code development and testing section in the example42 blog summary |
Hi @tuxmea , yeah! we did it, all checks are passed and my master branch is used by me in production so Prometheus 2.0.0 is working very well ! I thinks we are ready to merge branch . Thanks for awesome collaboration. |
looks good to me. @bastelfreak any comments from your side? |
Starting with 0.13.0, options must be given with two dashes instead of one. This patch is borrowed from the larger (and as of time of writing unmerged) PR found here: Once voxpupuli#144 has been merged, this entire fork can go away.
hi @tuxmea , I'll say Regards |
;-) merging now. |
adding remote_write support
adding remote_write support
Hi,
Adding remote_write support for prometheus 2.X
https://prometheus.io/docs/prometheus/latest/configuration/configuration/#%3Cremote_write%3E
BR
Karen