Convert to data-in-modules #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
added
enhancement
bastelfreak
force-pushed
the
cleanup
branch
2 times, most recently
from
cc7dcee
to
ecfa60c
Compare
bastelfreak
force-pushed
the
cleanup
branch
4 times, most recently
from
716095f
to
a326a11
Compare
|
There are a few things that currently don't get their default value from the params.pp. I didn't move those to hiera. The diff is already pretty big. We can migrate the other params in another PR. |
juniorsysadmin
approved these changes
Mar 22, 2018
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Convert to data-in-modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.