Add support for mysqld_exporter version 0.11.0 #247
Conversation
manifests/mysqld_exporter.pp
Outdated
| @@ -137,7 +137,7 @@ | |||
| notify => $notify_service, | |||
| } | |||
|
|
|||
| $options = "-config.my-cnf=${cnf_config_path} ${extra_options}" | |||
| $options = "--config.my-cnf==${cnf_config_path} ${extra_options}" | |||
There was a problem hiding this comment.
this change would make it backwards incompatible. Can you implement a selector statement that uses the old or the new syntax, depending on the version?
|
Hi @TheMeier, thanks for the PR. Can you please take a look at the inline comment I made? Also please rebase and take a look at the used email address. It isn't associated with your github account. |
|
@bastelfreak i am not so sure this can be done in a non backward-breaking way. The point is users could be using |
|
Also rebased.. |
|
ping |
|
Whatever we do here, we should probably also do on #179 |
data/defaults.yaml
Outdated
| @@ -168,7 +168,7 @@ prometheus::mysqld_exporter::group: 'mysqld-exporter' | |||
| prometheus::mysqld_exporter::package_ensure: 'latest' | |||
| prometheus::mysqld_exporter::package_name: 'mysqld_exporter' | |||
| prometheus::mysqld_exporter::user: 'mysqld-exporter' | |||
| prometheus::mysqld_exporter::version: '0.9.0' | |||
| prometheus::mysqld_exporter::version: '0.11.0' | |||
There was a problem hiding this comment.
Perhaps we should support the newer version, but leave the default alone? We could later update several exporter default versions in a single breaking change in a different PR?
There was a problem hiding this comment.
This sounds like a good compromise to me. It users to upgrade withought changing any of the current behaviour.
Flags now use the Kingpin library, and require double-dashes. prometheus/mysqld_exporter#222 Breaking change: if you do not set a version for mysqld_exporter *and* set `extra_options` make sure you update `extra_options` to be compatible with version 0.11.0 and greater.
bastelfreak
changed the title
|
@TheMeier thanks for the updates. Can you please add an acceptance test that installs version |
|
@bastelfreak done |
|
@TheMeier Thanks! |
Flags now use the Kingpin library, and require double-dashes. prometheus/mysqld_exporter#222
Flags now use the Kingpin library, and require double-dashes. prometheus/mysqld_exporter#222
Pull Request (PR) description
Update mysqld_exporter version to 0.11.0
mysqld_exporter flags now use the Kingpin library, and require double-dashes. prometheus/mysqld_exporter#222
Breaking change: if you do not set a version for mysqld_exporter and set
extra_optionsmake sureyou update
extra_optionsto be compatible with version 0.11.0 and greater.