Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render alerts file properly depending on prometheus version #253

Merged
merged 2 commits into from
Aug 18, 2018
Merged

Render alerts file properly depending on prometheus version #253

merged 2 commits into from
Aug 18, 2018

Conversation

bastelfreak
Copy link
Member

Fixes #252

Without this change, the alerts file will always be rendered in the prometheus v1 format.

@bastelfreak bastelfreak added the bug Something isn't working label Aug 18, 2018
Copy link
Member

@mmerfort mmerfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bastelfreak bastelfreak merged commit a4281f6 into voxpupuli:master Aug 18, 2018
@bastelfreak bastelfreak deleted the tests2 branch August 18, 2018 19:34
@bastelfreak bastelfreak changed the title add prometheus server version to alerts resource Render alerts file properly depending on prometheus version Aug 18, 2018
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
add prometheus server version to alerts resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants