Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Alertmanager config #277

Merged
merged 13 commits into from
May 30, 2019
Merged

Validate Alertmanager config #277

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
18e55b0
Validate Alertmanager config
allangood Oct 22, 2018
2c73ee8
Fixed lint and require parameter
allangood Oct 23, 2018
49404b6
Removed trailing whitespace
allangood Oct 23, 2018
54bcc47
Uses bind_dir
allangood Oct 23, 2018
e1963e9
Update alertmanager.pp
allangood Oct 24, 2018
4378161
Identation corrected
allangood Oct 24, 2018
f5eb5f5
Corrected notify service
allangood Oct 25, 2018
2c2ea34
Acceptance test for Alertmanager
allangood May 21, 2019
aaeb4f8
Alertmanager acceptance test via class
allangood May 21, 2019
add5e0d
Using my tested config for Alertmanager
May 30, 2019
3583b09
Minimal configuration for Alertmanager
May 30, 2019
71d6190
Fixed syntax, added missing closing braces
May 30, 2019
9052f51
Removed IPv4 configuration to allow IPv6 test
May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 27 additions & 8 deletions manifests/alertmanager.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,14 +183,33 @@
recurse => $purge_config_dir,
}

file { $config_file:
ensure => present,
owner => $user,
group => $group,
mode => $config_mode,
content => template('prometheus/alertmanager.yaml.erb'),
notify => $notify_service,
require => File[$config_dir],
if ( versioncmp($version, '0.10.0') >= 0 ) {
# If version >= 0.10.0 then install amtool - Alertmanager validation tool
file {"${bin_dir}/amtool":
ensure => link,
target => "/opt/${package_name}-${version}.${os}-${arch}/amtool",
}

file { $config_file:
ensure => present,
owner => $user,
group => $group,
mode => $config_mode,
content => template('prometheus/alertmanager.yaml.erb'),
notify => $notify_service,
require => File["${bin_dir}/amtool", $config_dir],
validate_cmd => "${bin_dir}/amtool check-config --alertmanager.url='' %",
}
} else {
file { $config_file:
ensure => present,
owner => $user,
group => $group,
mode => $config_mode,
content => template('prometheus/alertmanager.yaml.erb'),
notify => $notify_service,
require => File[$config_dir],
}
}

if $facts['prometheus_alert_manager_running'] == 'running' {
Expand Down
19 changes: 19 additions & 0 deletions spec/acceptance/alertmanager_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
require 'spec_helper_acceptance'

describe 'prometheus alertmanager' do
it 'alertmanager works idempotently with no errors' do
pp = "class { 'prometheus::alertmanager': }"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the previous style was correct, you can undo the last commit.

# Run it twice and test for idempotency
apply_manifest(pp, catch_failures: true)
apply_manifest(pp, catch_changes: true)
end

describe service('alertmanager') do
it { is_expected.to be_running }
it { is_expected.to be_enabled }
end
# the class installs an the alertmanager that listens on port 9093
describe port(9093) do
it { is_expected.to be_listening.with('tcp6') }
end
end