subbing out @name in stop function with an ambiguous name. #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @strings48066, thanks for the bugfix! |
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
subbing out @name in stop function with an ambiguous name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The template daemon.sysv.erb creates a variable name using @name as its value. When applying the process-exporter this variable is named process-exporter and produces the following:
$ service process-exporter stop
Shutting down prometheus process-exporter: /etc/init.d/process-exporter: line 68: process-exporter_pid=17693: command not found
Modified the variable creation to use a static name that conforms to the naming rules for variables.
This Pull Request (PR) fixes the following issues
Fixes #311