pushgateway: use correct CPU architecture & add acceptance tests #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past, this class relied on the actual architecture reported by facter, not by the normalized version from our main class. On CentOS, under certain conditions, this will not work and report x86_64 instead of amd64.
foxxx0
approved these changes
Jul 15, 2019
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
pushgateway: use correct CPU architecture & add acceptance tests
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
pushgateway: use correct CPU architecture & add acceptance tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, this class relied on the actual architecture reported by
facter, not by the normalized version from our main class. On CentOS,
under certain conditions, this will not work and report x86_64 instead
of amd64. This is the bugfix for #341
Without this fix, the acceptance tests won't work.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues