Allow s3 sources for download uris #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd appreciate a review when you get a chance @bastelfreak or @dhollinger. Thanks! |
|
Thanks for the PR @hooten ! |
|
Thanks for the review @bastelfreak ! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Jan 21, 2021
Allow s3 sources for download uris
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Allow s3 sources for download uris
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR adds the ability to specify an AWS S3 uri as the download uri source for a given
archive, e.g.,The PR does so by adding a type alias for
Uriwhich is aVariantofhttp,https, ands3and using it as the type of variousdownload_urlin class definitions.Using S3 buckets is already supported for the
Archivemodule. This change merely relaxes the type validation in order to add said support.https://github.com/voxpupuli/puppet-archive/blob/master/README.md#s3-bucket
This Pull Request (PR) fixes the following issues
n/a