Add service restart on package change #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rwaffen, thanks for the PR. Can you add an acceptance test for this? Maybe someting that installs the package, upgrades it and checks that the new version is running? |
|
I'm not sure. I didn't do any acceptance test until now in puppet 🤔 |
|
I did some tests locally. It's a bit ugly to write a test for this because we would need to get a package update which would trigger this. I checked the dependencies and the change looks fine. |
|
yeah, was thinking about that, how to get an update. many thanks for the testing and merging 👍 . |
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Jan 21, 2021
Add service restart on package change
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Add service restart on package change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add service restart on package change