Add parameter max_open_files to server class #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baurmatt
requested changes
Feb 12, 2020
|
Rspec-Test added |
baurmatt
approved these changes
Feb 12, 2020
There was a problem hiding this comment.
LGTM but as @kubicgruenfeld is a colleague of mine I will give others a change to review this as well :)
kubicgruenfeld
force-pushed
the
max-open-files-server
branch
from
7749391
to
056e543
Compare
|
thanks for the PR @kubicgruenfeld :) |
baurmatt
changed the title
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
add parameter max_open_files to server class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
we are using the server subclass directly in our wrapper module and so it is needed to be able to configure max_open_files also there.