Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon #650

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Add favicon #650

merged 1 commit into from
Nov 29, 2021

Conversation

gdubicki
Copy link
Member

@gdubicki gdubicki commented Nov 28, 2021

with the orange color taken from the voxpupuli logo.

Screenshot 2021-11-28 at 17 27 56

Based on the icon created by Jonathan Coutiño
(https://thenounproject.com/ralts01/) under
the Attribution 3.0 Unported (CC BY 3.0) license
(https://creativecommons.org/licenses/by/3.0/),
downloaded from the Noun Project (https://thenounproject.com).

@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #650 (5ac830f) into master (3c0df3c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   80.87%   80.87%           
=======================================
  Files          12       12           
  Lines         889      889           
=======================================
  Hits          719      719           
  Misses        170      170           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c0df3c...5ac830f. Read the comment docs.

@gdubicki
Copy link
Member Author

Just to clarify: I don't want to make it an "official" logo or such thing. I am afraid that trying to do that would result in a lot of bikeshedding.

This is just a favicon that looks like a board (to me) and has a voxpupuli color that I propose to add for a purely practical reason: it's faster to find a tab in a browser if it has a distinctive icon instead of having to read the title.

@bastelfreak
Copy link
Member

can you please rebase against master so we get rid of the merge commit?

with the orange color taken from the voxpupuli logo.

Based on the icon created by Jonathan Coutiño
(https://thenounproject.com/ralts01/) under
the Attribution 3.0 Unported (CC BY 3.0) license
(https://creativecommons.org/licenses/by/3.0/),
downloaded from the Noun Project (https://thenounproject.com).
@gdubicki
Copy link
Member Author

Sure, rebased.

@gdubicki gdubicki merged commit bbb879a into voxpupuli:master Nov 29, 2021
@gdubicki gdubicki deleted the favicon branch November 29, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants