Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regressions in v3.4.0 RC2 #661

Merged
merged 6 commits into from
Feb 15, 2022
Merged

Fix regressions in v3.4.0 RC2 #661

merged 6 commits into from
Feb 15, 2022

Conversation

gdubicki
Copy link
Member

Fixes (some) of #658.

For now fix showing certname as URL in Query view.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #661 (16163c5) into master (f50f278) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
- Coverage   82.72%   82.45%   -0.28%     
==========================================
  Files          12       11       -1     
  Lines         903      889      -14     
==========================================
- Hits          747      733      -14     
  Misses        156      156              
Impacted Files Coverage Δ
puppetboard/core.py 100.00% <100.00%> (ø)
puppetboard/utils.py 93.02% <100.00%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50f278...16163c5. Read the comment docs.

@gdubicki gdubicki marked this pull request as ready for review February 15, 2022 21:13
@gdubicki gdubicki merged commit 729a9f3 into voxpupuli:master Feb 15, 2022
@gdubicki gdubicki deleted the fix_regressions branch February 15, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants