Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed error styling from debug lines on report #725

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Removed error styling from debug lines on report #725

merged 1 commit into from
Dec 1, 2022

Conversation

shawntoffel
Copy link
Contributor

Hello,

With many debug messages it becomes difficult to quickly pick out any error messages on a report page. This change removes the 'error' css class from debug rows so that debug level rows are left as white. Open to alternatives.

Thank you.

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 85.43% // Head: 85.43% // No change to project coverage 👍

Coverage data is based on head (ced26a7) compared to base (9c41b29).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #725   +/-   ##
=======================================
  Coverage   85.43%   85.43%           
=======================================
  Files          19       19           
  Lines        1078     1078           
=======================================
  Hits          921      921           
  Misses        157      157           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gdubicki
Copy link
Member

gdubicki commented Dec 1, 2022

Hi @shawntoffel! Thank you for the contribution. Could you please add a screenshots to show how this would look like? Preferably before and after, but at least after would be helpful.

@shawntoffel
Copy link
Contributor Author

Here are screenshots of the same report before and after. They are large and zoomed out for clear demonstration.

Before

before

After

after
afternormalzoom

@gdubicki
Copy link
Member

gdubicki commented Dec 1, 2022

Thanks, now that I see this it’s clear that this change makes a lot of sense!

@gdubicki gdubicki merged commit 445b959 into voxpupuli:master Dec 1, 2022
@shawntoffel shawntoffel deleted the report-debug-color branch December 2, 2022 02:45
@gdubicki
Copy link
Member

Released in v4.2.2 a moment ago. Thanks for your contribution, @shawntoffel!

@shawntoffel
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants