Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README for SECRET_KEY and SSL Setup #985

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Update README for SECRET_KEY and SSL Setup #985

merged 3 commits into from
Dec 5, 2023

Conversation

tuxmea
Copy link
Member

@tuxmea tuxmea commented Dec 1, 2023

  • add section on SECRET_KEY
  • add example for PuppetDB SSL within Puppet code
  • correct parameter explanation

@tuxmea
Update README
20bf3cc 
- add section on SECRET_KEY
- add example for PuppetDB SSL within Puppet code
- correct parameter explanation
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ee6e75) 76.87% compared to head (2d71904) 76.87%.

❗ Current head 2d71904 differs from pull request most recent head d2fc2ef. Consider uploading reports for the commit d2fc2ef to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #985   +/-   ##
=======================================
  Coverage   76.87%   76.87%           
=======================================
  Files          20       20           
  Lines        1310     1310           
=======================================
  Hits         1007     1007           
  Misses        303      303

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gdubicki
gdubicki approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@gdubicki gdubicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but LGTM in general! Thank you for the contribution, @tuxmea!

README.md Outdated Show resolved Hide resolved
@tuxmea
Update comment on secret key generation
2d71904 
make it clear, that the code is an example.
@tuxmea tuxmea requested a review from gdubicki December 5, 2023 07:13
@bastelfreak bastelfreak changed the title Update README Update README for SECRET_KEY and SSL Setup Dec 5, 2023
@bastelfreak bastelfreak merged commit b7ffe4b into voxpupuli:master Dec 5, 2023
7 checks passed
@tuxmea tuxmea deleted the update_readme branch December 5, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@binford2k binford2k Awaiting requested review from binford2k

@rwaffen rwaffen Awaiting requested review from rwaffen

@gdubicki gdubicki Awaiting requested review from gdubicki

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuxmea @bastelfreak @gdubicki