-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build as Self Contained and Selfhost CefSharp SubProcess #693
Build as Self Contained and Selfhost CefSharp SubProcess #693
Conversation
@Myrkie @Natsumi-sama @BenjaminZehowlt |
@Okabintaro Can you try this install? |
That one works fine! I also made an issue for my previous problem in #695. |
could this be an extra build artifact, offering two versions; one self contained and one using the system .net install? |
While that's something that could be done, would require effort. I don't see any significant enough of a downside of this. |
Sometimes more options isn't better, this certainly one of those times, it's not worth the time explaining the difference in builds every time to people that just don't care or notice. |
fair, thought of that too, I just like having options. (and I like having my dependencies installed system wide - shared across apps) |
It seems building with |
I removed that removal from the csproj though, should be included now, no? - <CefSharpExcludeSubProcessExe>true</CefSharpExcludeSubProcessExe> Removal was removed here: https://github.com/vrcx-team/VRCX/pull/693/files#diff-fcda6e0752ad20a00c16d8f4d2461f9c44e0a954c09bbefd406bc79465a61a38L34 |
Yeeeeea that was it, I'm not sure how I manged to miss that. |
* Added self contained parameter to builds * Remove dotnet install from installer * Fixed missing SubProcessExe * Self hot browser subprocess --------- Co-authored-by: Natsumi <cmcooper123@hotmail.com>
This changes the build of VRCX to be self-contained, removing the requirement of installing dotnet, and not having to deal with potential bad dotnet installs.
Pros
Cons
Pro/Con
Not Changed