TryGetComponent に書き換え #2380
Merged
TryGetComponent に書き換え #2380
+598
−655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ousttrue
commented
Jul 24, 2024
| @@ -137,7 +137,7 @@ public static IEnumerable<Validation> Validate_TPose(GameObject ExportRoot) | |||
| { | |||
| getBoneTransform = humanoid.GetBoneTransform; | |||
| } | |||
| else if (ExportRoot.GetComponent<Animator>() is Animator animator) | |||
| else if (ExportRoot.GetComponent<Animator>() is Animator animator && animator != null) | |||
There was a problem hiding this comment.
とりあえずこれで直るのだけど、他の場所にもありそう・・・
Santarh
previously approved these changes
Jul 24, 2024
There was a problem hiding this comment.
この目的なら TryGetComponent<T> が良いと思われます
https://docs.unity3d.com/2021.3/Documentation/ScriptReference/Component.TryGetComponent.html
|
間違えた、Request Changes です |
|
ついでなので、他の場所も TryGetComponent に書き換えます。 |
ousttrue
changed the title
TryGetComponent GetComponentOrThrow(拡張関数) GetComponentOrNull(拡張関数) sample と test は据え置き
Animator.GetBoneTransform のために GetComponent しているところの Export Error を修正するついでに、 Animator.GetBoneTransform と Humanoid.GetBoneTransform 両対応とした(vrm-0.x と vrm-1.0 両方)。
Santarh
approved these changes
Jul 25, 2024
|
|
||
| if (vrmMeta == null) | ||
| if (root.TryGetComponent<Vrm10Instance>(out var vrmController)) |
There was a problem hiding this comment.
リファクタ系の PullReq はリファクタだけにしてもらえると、 diff を読む時間をかなり減らせてうれしいです
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
エラー
attach されていない場合でも is 演算子が true になって後続で例外になる
再現手順。
vrm-1.0 の seed-san vrm の拡張子を glb に変える。
glb として import して、prefab をシーンに展開。
VRM-1.0 の export dialog に投入する。
備考
UnityのGetCompornent()でNull条件演算子が使えない
に類似する問題と思われる。
#2319 と現象が似ている。
Validation で繰り返し例外が発生してしまう。